feat: implement js client for social inbox #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RangerMauve
requested changes
Nov 23, 2023
There was a problem hiding this comment.
API structure looks good.
Mind replacing fetch with https://www.npmjs.com/package/http-signed-fetch
Also could you write a test that starts a local server and uses the client to talk to it.
akhileshthite
force-pushed
the
js-client
branch
from
0f57a6b to
683f789
Compare
RangerMauve
requested changes
Nov 29, 2023
src/client/index.ts
Outdated
| const response = await this.fetch(url, { | ||
| method, | ||
| headers: { | ||
| 'Content-Type': finalContentType | ||
| }, | ||
| body | ||
| body, | ||
| publicKeyId: this.keypair.publicKeyId, |
There was a problem hiding this comment.
This field does not exist, it should be passed in as an option. Surprised the lint step missed this.
RangerMauve
requested changes
Dec 18, 2023
src/client/index.ts
Outdated
| } | ||
|
|
||
| // Followers | ||
| async listFollowers (actor: string): Promise<string[]> { |
There was a problem hiding this comment.
Everywhere we pass an actor, have it be set to this.actor as a default and make sure it's the last argument.
RangerMauve
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hyphacoop/distributed-press-organizing#97