fix: ledger wallet #530
Merged
fix: ledger wallet #530
+94
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes the missing `getOfflineSigner` implementation - Fixes `StdSignDoc` serialization to JSON. The object MUST be serialized in lexicographical key order - Replace the encoding of `pubkey` in `getAccount` from a `TextEncoder` to using the `fromHex` function.
fmorency
commented
Jan 10, 2025
| @@ -1,7 +1,7 @@ | |||
| import { ChainRecord, ChainWalletBase, Wallet } from '@cosmos-kit/core'; | |||
|
|
|||
| export class LedgerChianWallet extends ChainWalletBase { | |||
| export class LedgerChainWallet extends ChainWalletBase { | |||
There was a problem hiding this comment.
Fix typo and prettify
| @@ -39,16 +47,44 @@ export class LedgerClient implements WalletClient { | |||
| username: username ?? path, | |||
| address, | |||
| algo: 'secp256k1' as Algo, | |||
| pubkey: new TextEncoder().encode(publicKey), | |||
| pubkey: fromHex(publicKey), | |||
There was a problem hiding this comment.
We want the publicKey as an hex byte array, not a UTF-8 byte array
|
Only |
pyramation
reviewed
Jan 14, 2025
| import TransportWebUSB from '@ledgerhq/hw-transport-webusb'; | ||
| import TransportWebHID from '@ledgerhq/hw-transport-webhid' | ||
| import { chains } from 'chain-registry'; |
There was a problem hiding this comment.
we should re-think this
|
Thanks so much @fmorency :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getOfflineSignerimplementationStdSignDocserialization to JSON. The object MUST be serialized in lexicographical key order 1pubkeyingetAccountfrom aTextEncoderto using thefromHexfunction@ledgerhq/*dependenciesFixes #497