chore: minor changes to dynamic label part of label application rule #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String TOKEN_EXTRACTION_RULES_KEY = "tokenExtractionRules"; | ||
|
|
||
| @GraphQLField | ||
| @GraphQLName(LABEL_EXPRESSION_KEY) | ||
| @GraphQLName(EXPRESSION_KEY) | ||
| @GraphQLNonNull |
There was a problem hiding this comment.
All new fields should include @GraphQlDescription - these relatively convoluted APIs would be a great spot for them too, since we can include an example of the type of syntax expected here
...pl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java
Show resolved
Hide resolved
...pl/src/main/java/org/hypertrace/graphql/label/dao/LabelApplicationRuleResponseConverter.java
Outdated
Show resolved
Hide resolved
aaron-steinfeld
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.