chore: Add support for dynamic expression in label application rules #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron-steinfeld
approved these changes
Jun 11, 2024
| @GraphQLField | ||
| @GraphQLName(LABEL_EXPRESSION_KEY) | ||
| @GraphQLNonNull | ||
| String labelExpression(); |
There was a problem hiding this comment.
maybe labelExpressionTemplate ?
There was a problem hiding this comment.
It is named as label_expression in config service. Should we just keep the names aligned?
There was a problem hiding this comment.
Keeping names aligned for now
There was a problem hiding this comment.
I don't think so, the internal name is bad and now an expression object contains an expression. Getting the user facing name right is more important than matching the internal config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.