Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add common labels, annotation and security context to pods #243

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

ravisingal
Copy link
Contributor

No description provided.

@ravisingal ravisingal requested a review from a team as a code owner September 27, 2024 15:13
Copy link
Contributor

github-actions bot commented Sep 27, 2024

Test Results

111 tests  ±0   111 ✅ ±0   15s ⏱️ ±0s
 25 suites ±0     0 💤 ±0 
 25 files   ±0     0 ❌ ±0 

Results for commit 972ceaf. ± Comparison against base commit 2b75ee6.

♻️ This comment has been updated with latest results.

abeytom07
abeytom07 previously approved these changes Sep 27, 2024
@aaron-steinfeld
Copy link
Contributor

let me update the locks to resolve these dep issues, one sec

@aaron-steinfeld
Copy link
Contributor

Done. Can update branch

@ravisingal
Copy link
Contributor Author

Done. Can update branch

oh.. I also pushed it.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean merge :)

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.23%. Comparing base (ad56e3b) to head (972ceaf).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #243      +/-   ##
============================================
+ Coverage     68.52%   77.23%   +8.70%     
+ Complexity      270      151     -119     
============================================
  Files            30       35       +5     
  Lines           931     1050     +119     
  Branches         76       81       +5     
============================================
+ Hits            638      811     +173     
+ Misses          252      186      -66     
- Partials         41       53      +12     
Flag Coverage Δ
integration 77.23% <ø> (?)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ravisingal ravisingal merged commit e0831f1 into main Sep 27, 2024
11 checks passed
@ravisingal ravisingal deleted the common-labels-annotations branch September 27, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants