Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test logging trivy #198

Closed
wants to merge 3 commits into from
Closed

ci: test logging trivy #198

wants to merge 3 commits into from

Conversation

aaron-steinfeld
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Copy link
Contributor

github-actions bot commented Nov 7, 2023

Test Results

103 tests  ±0   103 ✔️ ±0   13s ⏱️ ±0s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ±0 

Results for commit 1f4cd88. ± Comparison against base commit f13783d.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #198 (1f4cd88) into main (f13783d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #198   +/-   ##
=========================================
  Coverage     83.16%   83.16%           
  Complexity      282      282           
=========================================
  Files            33       33           
  Lines           968      968           
  Branches         74       74           
=========================================
  Hits            805      805           
  Misses          111      111           
  Partials         52       52           
Flag Coverage Δ
integration 83.16% <ø> (ø)
unit 68.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aaron-steinfeld
Copy link
Contributor Author

So the issue here appears to be in the upload. When using trivy's log output, there are no actual vulns.

@aaron-steinfeld aaron-steinfeld deleted the test-trivy branch November 8, 2023 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant