Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update bom #197

Merged
merged 9 commits into from
Nov 7, 2023
Merged

build: update bom #197

merged 9 commits into from
Nov 7, 2023

Conversation

aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Nov 5, 2023

Description

Manual lock update and CI fix to support autobuild with locks

Copy link
Contributor

github-actions bot commented Nov 5, 2023

Test Results

103 tests  ±0   103 ✔️ ±0   14s ⏱️ -6s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ±0 

Results for commit 16d18dc. ± Comparison against base commit 8f218bf.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 5, 2023

Codecov Report

Merging #197 (16d18dc) into main (8f218bf) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #197   +/-   ##
=========================================
  Coverage     83.16%   83.16%           
  Complexity      282      282           
=========================================
  Files            33       33           
  Lines           968      968           
  Branches         74       74           
=========================================
  Hits            805      805           
  Misses          111      111           
  Partials         52       52           
Flag Coverage Δ
integration 83.16% <ø> (ø)
unit 68.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@aaron-steinfeld aaron-steinfeld marked this pull request as ready for review November 6, 2023 23:19
@aaron-steinfeld aaron-steinfeld requested review from a team as code owners November 6, 2023 23:19
@@ -27,6 +27,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v3
with:
fetch-depth: 0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was hard to track down but eventually isolated it to the lack of history broke the local version calculation and led to the local build being mismatched with the locks (if the bom contains self references, since we recently added attribute service to bom).

@aaron-steinfeld aaron-steinfeld merged commit f13783d into main Nov 7, 2023
11 checks passed
@aaron-steinfeld aaron-steinfeld deleted the test-bom branch November 7, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants