Skip to content

Commit

Permalink
Merge pull request #1958 from web3j/nicks/integrationTests-fix
Browse files Browse the repository at this point in the history
Fix integration tests
  • Loading branch information
gtebrean authored Sep 20, 2023
2 parents e0b4b1e + f2e1c87 commit ac0618c
Show file tree
Hide file tree
Showing 114 changed files with 5,265 additions and 493 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,7 @@ docs/build
**/.settings
**/bin

web3j.asc
web3j.asc

# Besu-dev-quickstart logs
integration-tests/src/test/resources/quorum-test-network/logs
7 changes: 6 additions & 1 deletion core/src/main/java/org/web3j/protocol/admin/Admin.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,12 @@
import org.web3j.protocol.core.methods.request.Transaction;
import org.web3j.protocol.core.methods.response.EthSendTransaction;

/** JSON-RPC Request object building factory for common Parity and Geth. */
/**
* JSON-RPC Request object building factory for common Parity and Geth. Personal namespace has now
* been deprecated in favour of using Clef as an external signer and account manager. Read more -
* https://geth.ethereum.org/docs/interacting-with-geth/rpc/ns-personal
*/
@Deprecated()
public interface Admin extends Web3j {

static Admin build(Web3jService web3jService) {
Expand Down
3 changes: 1 addition & 2 deletions integration-tests/src/test/java/org/web3j/ens/EnsIT.java
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,9 @@
public class EnsIT {

@Test
public void testEns(Web3j web3j) throws Exception {
public void testEns(Web3j web3j) {

EnsResolver ensResolver = new EnsResolver(web3j);

assertEquals(
ensResolver.resolve("web3j.test"), ("0x19e03255f667bdfd50a32722df860b1eeaf4d635"));
}
Expand Down

This file was deleted.

Loading

0 comments on commit ac0618c

Please sign in to comment.