Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip problem seeds for view change simulation tests. #1525

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Skip problem seeds for view change simulation tests. #1525

merged 2 commits into from
Mar 24, 2021

Conversation

Toktar
Copy link
Contributor

@Toktar Toktar commented Mar 15, 2021 •
edited
Loading

Because of the issue #1506

@Toktar Toktar requested a review from a team as a code owner March 15, 2021 22:09
@WadeBarnes
Copy link
Member

(ci) test this please.

@WadeBarnes
Copy link
Member

(ci) test this please

@WadeBarnes
Copy link
Member

Tests still failing.

WadeBarnes
WadeBarnes requested changes Mar 23, 2021
View reviewed changes
Copy link
Member

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look into why the tests (Jenkins) continue to fail.

@Toktar
Copy link
Contributor Author

Toktar commented Mar 24, 2021

@WadeBarnes Added new changes. Tests passed. Could you please review it?

@WadeBarnes WadeBarnes merged commit 705582e into hyperledger:master Mar 24, 2021
@WadeBarnes WadeBarnes mentioned this pull request Nov 8, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WadeBarnes WadeBarnes WadeBarnes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Toktar @WadeBarnes