Fix indy-node devcontainer build issues #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wade Barnes <[email protected]>
dbluhm
previously approved these changes
Nov 2, 2023
- This is a workaround to get the indy-node devcontainer to build. - Pin the version of `Cython` to `0.29.36` which is the last release before the v3 releases that cause the build errors. - `Cython` - `python-rocksdb` python package dependency is actually at the indy-plenum level, so it needs to be fixed there. Signed-off-by: Wade Barnes <[email protected]>
WadeBarnes
changed the title
|
@swcurran, Would you mind approving? |
jovfer
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to fix the indy-node devcontainer issues reported in #1822. The dependency issues are actually at the indy-plenum level. I'll be opening a ticket for the issue there.
fixes: #1822