Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SET_FEES, GET_FEE and GET_FEES txns #1653

Open
wants to merge 7 commits into
base: ubuntu-16.04
Choose a base branch
from

Conversation

Toktar
Copy link
Contributor

@Toktar Toktar commented Feb 16, 2021

No description provided.

@Toktar Toktar changed the title UP-41: add SET_FEES, GET_FEE and FET_FEES txns [WIP][UP-41] add SET_FEES, GET_FEE and FET_FEES txns Feb 16, 2021
@Toktar Toktar changed the title [WIP][UP-41] add SET_FEES, GET_FEE and FET_FEES txns UP-41: add SET_FEES, GET_FEE and FET_FEES txns Feb 20, 2021
askolesov
askolesov previously approved these changes Feb 24, 2021
Copy link
Contributor

@askolesov askolesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WadeBarnes
Copy link
Member

@Toktar, Can you remind me which HIPE is associated to this work?

@brentzundel brentzundel changed the title UP-41: add SET_FEES, GET_FEE and FET_FEES txns UP-41: add SET_FEES, GET_FEE and GET_FEES txns Mar 24, 2021
@brentzundel
Copy link
Contributor

a HIPE describing fee transactions for Indy is here: https://github.com/hyperledger/indy-hipe/tree/master/text/0161-generic-token, but it is not clear to me that the HIPE was used as the specification for this PR.
Do the GET_FEES and SET_FEES transaction described in the HIPE match the ones implemented here?
The HIPE also describes COLLECT_FEES and UNCOLLECTED_FEES that are not implemented here, unless one of them maps to GET_FEE. Where is GET_FEE described?

@askolesov
Copy link
Contributor

askolesov commented Mar 25, 2021

@askolesov
Copy link
Contributor

@Toktar Should we merge it in case we don't remove tokens? I think no. Please correct me if I'm wrong.

@brentzundel
Copy link
Contributor

Here is the HIPE:
https://github.com/hyperledger/indy-hipe/tree/master/text/0163-default-fee-handler

This HIPE does not describe GET_FEES nor GET_FEE, can you point me to documentation of those transactions?

@Toktar Toktar changed the title UP-41: add SET_FEES, GET_FEE and GET_FEES txns Add SET_FEES, GET_FEE and GET_FEES txns Apr 13, 2021
@cjhowland
Copy link
Contributor

@Toktar Could you provide a brief update on this PR? With recent branch changes and the current development process on Indy Node/Plenum, we are wondering if these changes are still viable. If so, please close this PR and retarget it to main.

We will discuss and determine which PRs should be merged or closed at the next Indy Contributors Working Group meeting on May 9, 2023.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants