-
Notifications
You must be signed in to change notification settings - Fork 656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SET_FEES, GET_FEE and GET_FEES txns #1653
base: ubuntu-16.04
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: toktar <[email protected]> Signed-off-by: Ry Jones <[email protected]>
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
Signed-off-by: toktar <[email protected]>
@Toktar, Can you remind me which HIPE is associated to this work? |
a HIPE describing fee transactions for Indy is here: https://github.com/hyperledger/indy-hipe/tree/master/text/0161-generic-token, but it is not clear to me that the HIPE was used as the specification for this PR. |
@Toktar Should we merge it in case we don't remove tokens? I think no. Please correct me if I'm wrong. |
This HIPE does not describe GET_FEES nor GET_FEE, can you point me to documentation of those transactions? |
@Toktar Could you provide a brief update on this PR? With recent branch changes and the current development process on Indy Node/Plenum, we are wondering if these changes are still viable. If so, please close this PR and retarget it to We will discuss and determine which PRs should be merged or closed at the next Indy Contributors Working Group meeting on May 9, 2023. |
No description provided.