Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Warning on Invitation generated on Issuance #1433

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mineme0110
Copy link
Contributor

@mineme0110 mineme0110 commented Nov 5, 2024

Description:

Warning is generated in connection flow which is confusing it doesn't block the flow will be good address the unecessary noise
#1426

Alternatives Considered (optional):

Link to existing ADR (Architecture Decision Record), if any. If relevant, describe other approaches explored and the selected approach. Documenting why the methods were not selected will create a knowledge base for future reference, helping prevent others from revisiting less optimal ideas.

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@mineme0110 mineme0110 requested a review from a team as a code owner November 5, 2024 11:11
@mineme0110 mineme0110 changed the title fix: Invitation generated no processing is required fix: Warning on Invitation generated on Issuance Nov 5, 2024
Copy link
Contributor

github-actions bot commented Nov 5, 2024

Integration Test Results

20 files  20 suites   3s ⏱️
53 tests 53 ✅ 0 💤 0 ❌
94 runs  94 ✅ 0 💤 0 ❌

Results for commit a8eeca3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 5, 2024

Unit Test Results

103 files  103 suites   20m 37s ⏱️
877 tests 869 ✅ 8 💤 0 ❌
884 runs  876 ✅ 8 💤 0 ❌

Results for commit a8eeca3.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

Coverage Status

coverage: 48.848% (+0.1%) from 48.748%
when pulling 8abdaf1 on fix/connectioles-ivitation
into 1c7c38e on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants