fix: Allow Apollo to verify der signatures from bc and bitcoin seamlessly #ATL-6905 #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elribonazo
requested review from
patlo-iog,
hamada147,
goncalo-frade-iohk and
cristianIOHK
elribonazo
changed the title
Code Coverage
|
…ssly. Will try validating bouncyCastle or convert to bouncy castle from bitcoin format. Signed-off-by: Francisco Javier Ribó Labrador <[email protected]>
elribonazo
force-pushed
the
feature/ATL-6907
branch
from
bc893d9 to
ce8a5e4
Compare
cristianIOHK
approved these changes
Apr 11, 2024
hamada147
approved these changes
Apr 11, 2024
patlo-iog
approved these changes
Apr 12, 2024
yshyn-iohk
approved these changes
Apr 12, 2024
|
@goncalo-frade-iohk I've just brought 50 tests pat shared with me from old prism-crypto, passing :) |
goncalo-frade-iohk
approved these changes
Apr 12, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
… bc and bitcoin seamlessly #ATL-6905 (#154)
atala-dev
added a commit
that referenced
this pull request
Apr 12, 2024
## [1.2.14](v1.2.13...v1.2.14) (2024-04-12) ### Bug Fixes * Allow Apollo to verify der signatures from bc and bitcoin seamlessly #ATL-6905 ([#154](#154)) ([a26a559](a26a559)), closes [#ATL-6905](https://github.com/input-output-hk/atala-prism-apollo/issues/ATL-6905)
|
🎉 This PR is included in version 1.2.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 12, 2024
## [1.2.14](v1.2.13...v1.2.14) (2024-04-12) ### Bug Fixes * Allow Apollo to verify der signatures from bc and bitcoin seamlessly #ATL-6905 ([#154](#154)) ([a26a559](a26a559)), closes [#ATL-6905](https://github.com/input-output-hk/atala-prism-apollo/issues/ATL-6905)
hamada147
added a commit
that referenced
this pull request
May 20, 2024
…ssly #ATL-6905 (#154) Co-authored-by: Ahmed Moussa <[email protected]> Signed-off-by: Javi Ribo <[email protected]>
hamada147
pushed a commit
that referenced
this pull request
May 20, 2024
## [1.2.14](v1.2.13...v1.2.14) (2024-04-12) ### Bug Fixes * Allow Apollo to verify der signatures from bc and bitcoin seamlessly #ATL-6905 ([#154](#154)) ([a26a559](a26a559)), closes [#ATL-6905](https://github.com/input-output-hk/atala-prism-apollo/issues/ATL-6905)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Relates to [ATL-6907](https://input-output.atlassian.net/browse/ATL-6907) we are unlocking this functionality in Apollo to make sure that we can validate any kind of secp256k1 signature, from bc or bitcoin format.