Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The need to publish another module to use Apollo #149

Merged

Conversation

hamada147
Copy link
Contributor

@hamada147 hamada147 commented Mar 11, 2024

Overview

Remove Secp256k1-kmp module as dependency and use the module as source code only.

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

- Remove Secp256k1-kmp module as dependency and use the module as source code only.

Signed-off-by: Ahmed Moussa <[email protected]>
@atala-dev
Copy link
Contributor

Code Coverage

Total Project Coverage 91.69%

@hamada147 hamada147 merged commit 91554d9 into main Mar 11, 2024
2 checks passed
@hamada147 hamada147 deleted the remove-the-need-to-publish-another-module-to-use-Apollo branch March 11, 2024 21:15
github-actions bot pushed a commit that referenced this pull request Mar 11, 2024
atala-dev added a commit that referenced this pull request Mar 14, 2024
## [1.2.12](v1.2.11...v1.2.12) (2024-03-14)

### Bug Fixes

* The need to publish another module to use Apollo ([#149](#149)) ([91554d9](91554d9))
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Mar 14, 2024
## [1.2.12](v1.2.11...v1.2.12) (2024-03-14)

### Bug Fixes

* The need to publish another module to use Apollo ([#149](#149)) ([91554d9](91554d9))
hamada147 added a commit that referenced this pull request May 20, 2024
hamada147 pushed a commit that referenced this pull request May 20, 2024
## [1.2.12](v1.2.11...v1.2.12) (2024-03-14)

### Bug Fixes

* The need to publish another module to use Apollo ([#149](#149)) ([91554d9](91554d9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants