Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Apple crash when creating seed with empty string passphrase #146

Merged
merged 1 commit into from
Feb 21, 2024
Merged

fix: Apple crash when creating seed with empty string passphrase #146

merged 1 commit into from
Feb 21, 2024

Conversation

hamada147
Copy link
Contributor

Overview

Fixes Apple crash when creating seed with empty string passphrase

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@hamada147 hamada147 added the bug Something isn't working label Feb 21, 2024
@hamada147 hamada147 self-assigned this Feb 21, 2024
@atala-dev
Copy link
Contributor

Code Coverage

File Coverage [100.00%] ✅
apollo/src/appleMain/kotlin/io/iohk/atala/prism/apollo/hashing/PBKDF2SHA512.kt 100.00% ✅
Total Project Coverage 91.69% ✅

@hamada147 hamada147 merged commit ce739dd into main Feb 21, 2024
2 checks passed
@hamada147 hamada147 deleted the fix/apple-crash-when-passpharase-is-empty-is-create-seed branch February 21, 2024 20:54
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
@hamada147
feat(docs): (ce739dd) fix: Apple crash when creating seed with empty …
095e2d9 
…string passphrase (#146)
atala-dev added a commit that referenced this pull request Mar 6, 2024
@atala-dev
chore(release): cut apollo version 1.2.11
046e5de 
## [1.2.11](v1.2.10...v1.2.11) (2024-03-06)

### Bug Fixes

* Apple crash when creating seed with empty string passphrase ([#146](#146)) ([ce739dd](ce739dd))
* upgrade gradle & libs ([#147](#147)) ([b0906dd](b0906dd))
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.2.11 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Mar 6, 2024
@atala-dev
feat(docs): (046e5de) chore(release): cut apollo version 1.2.11
ce8e953 
## [1.2.11](v1.2.10...v1.2.11) (2024-03-06)

### Bug Fixes

* Apple crash when creating seed with empty string passphrase ([#146](#146)) ([ce739dd](ce739dd))
* upgrade gradle & libs ([#147](#147)) ([b0906dd](b0906dd))
hamada147 added a commit that referenced this pull request May 20, 2024
@hamada147
fix: Apple crash when creating seed with empty string passphrase (#146)
ccf6c52 
Signed-off-by: Ahmed Moussa <[email protected]>
hamada147 pushed a commit that referenced this pull request May 20, 2024
@atala-dev @hamada147
chore(release): cut apollo version 1.2.11
1cdc35a 
## [1.2.11](v1.2.10...v1.2.11) (2024-03-06)

### Bug Fixes

* Apple crash when creating seed with empty string passphrase ([#146](#146)) ([ce739dd](ce739dd))
* upgrade gradle & libs ([#147](#147)) ([b0906dd](b0906dd))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianIOHK cristianIOHK cristianIOHK approved these changes

@goncalo-frade-iohk goncalo-frade-iohk goncalo-frade-iohk approved these changes

@elribonazo elribonazo Awaiting requested review from elribonazo

@curtis-h curtis-h Awaiting requested review from curtis-h

Assignees

@hamada147 hamada147

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hamada147 @atala-dev @goncalo-frade-iohk @cristianIOHK