Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove if since the xcframework is not building with all targets #121

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Dec 5, 2023

Overview

We need to remove this If's since they are making that this targets are not built on xcframework final product ATL-6264

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@atala-dev
Copy link
Contributor

Code Coverage

Total Project Coverage NaN%

@goncalo-frade-iohk goncalo-frade-iohk merged commit e728572 into main Dec 5, 2023
2 checks passed
@goncalo-frade-iohk goncalo-frade-iohk deleted the feature/CIFixXCFramework branch December 5, 2023 17:38
atala-dev added a commit that referenced this pull request Dec 5, 2023
## [1.2.2](v1.2.1...v1.2.2) (2023-12-05)

### Bug Fixes

* remove if since the xcframework is not building with all targets ([#121](#121)) ([e728572](e728572))
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

hamada147 added a commit that referenced this pull request May 20, 2024
hamada147 pushed a commit that referenced this pull request May 20, 2024
## [1.2.2](v1.2.1...v1.2.2) (2023-12-05)

### Bug Fixes

* remove if since the xcframework is not building with all targets ([#121](#121)) ([e728572](e728572))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants