Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove failing links to unblock dokka documentation generation #120

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

cristianIOHK
Copy link
Contributor

@cristianIOHK cristianIOHK commented Dec 1, 2023

Overview

This PR fixes the documentation release action by removing the failing images.
They are the tags for what is supported, for example: kotlin, ios, jvm, js, getNode-js, and so on. If we require these links I would strongly suggest to include these images into the repo to not depend on external links, but in my honest opinion these are not a must and can be taken out.

fixes: ATL-6259

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@atala-dev
Copy link
Contributor

Code Coverage

Total Project Coverage NaN%

@hamada147 hamada147 force-pushed the fix-documentation-generation branch from 6d020d3 to 3f15f1d Compare December 5, 2023 14:27
@hamada147 hamada147 force-pushed the fix-documentation-generation branch from eb3b4a1 to b6e9259 Compare December 5, 2023 19:12
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
@cristianIOHK cristianIOHK merged commit 0e18bef into main Dec 5, 2023
2 checks passed
@cristianIOHK cristianIOHK deleted the fix-documentation-generation branch December 5, 2023 20:33
github-actions bot pushed a commit that referenced this pull request Dec 5, 2023
…mentation generation (#120)

Signed-off-by: Ahmed Moussa <[email protected]>
Co-authored-by: Ahmed Moussa <[email protected]>
atala-dev added a commit that referenced this pull request Dec 11, 2023
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11)

### Bug Fixes

* remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
@atala-dev
Copy link
Contributor

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Dec 11, 2023
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11)

### Bug Fixes

* remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
hamada147 added a commit that referenced this pull request May 20, 2024
hamada147 pushed a commit that referenced this pull request May 20, 2024
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11)

### Bug Fixes

* remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants