-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove failing links to unblock dokka documentation generation #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage
|
hamada147
force-pushed
the
fix-documentation-generation
branch
from
December 5, 2023 14:27
6d020d3
to
3f15f1d
Compare
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
hamada147
force-pushed
the
fix-documentation-generation
branch
from
December 5, 2023 19:12
eb3b4a1
to
b6e9259
Compare
Signed-off-by: Ahmed Moussa <[email protected]>
Signed-off-by: Ahmed Moussa <[email protected]>
hamada147
approved these changes
Dec 5, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Dec 5, 2023
…mentation generation (#120) Signed-off-by: Ahmed Moussa <[email protected]> Co-authored-by: Ahmed Moussa <[email protected]>
atala-dev
added a commit
that referenced
this pull request
Dec 11, 2023
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11) ### Bug Fixes * remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
🎉 This PR is included in version 1.2.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11) ### Bug Fixes * remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
hamada147
added a commit
that referenced
this pull request
May 20, 2024
…120) Signed-off-by: Cristian G <[email protected]> Co-authored-by: Ahmed Moussa <[email protected]>
hamada147
pushed a commit
that referenced
this pull request
May 20, 2024
## [1.2.3](v1.2.2...v1.2.3) (2023-12-11) ### Bug Fixes * remove failing links to unblock dokka documentation generation ([#120](#120)) ([0e18bef](0e18bef))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes the documentation release action by removing the failing images.
They are the tags for what is supported, for example: kotlin, ios, jvm, js, getNode-js, and so on. If we require these links I would strongly suggest to include these images into the repo to not depend on external links, but in my honest opinion these are not a must and can be taken out.
fixes: ATL-6259
Checklist
My PR contains...
My changes...
Documentation
Tests