Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated into Spanish the Fabric Gateway section and minor corrections #1292

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

munapower
Copy link
Contributor

Translated into Spanish the Fabric Gateway section of the Full Stack Asset Transfer sample. Also did minor corrections on the English version. Update the readme to add links to the Spanish version.

@munapower munapower requested a review from a team as a code owner January 16, 2025 19:25
Signed-off-by: munapower <[email protected]>
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this excellent contribution. The build failed on a linting check unrelated to this change. I fixed that in PR #1293 so rebasing on the latest branch content should resolve that failure for this PR.

bestbeforetoday and others added 3 commits January 17, 2025 08:28
The existing orderer configuration file is incompatible with v3.0,
and the v3.0 configuration does not work with v2.5.
To support both versions, configuration settings have been updated to
use environment variables instead of referencing static configuration
files.

Signed-off-by: Tatsuya Sato <[email protected]>
Copy link
Member

@bestbeforetoday bestbeforetoday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to have merged changes from the main branch rather than being rebased on it so now shows commits not related to this change. However, I think everything is consistent with the main branch content and everything will shake out when the commits from this PR are squashed, so I'll merge as-is.

Thank you for the contribution!

@bestbeforetoday bestbeforetoday merged commit 859c025 into hyperledger:main Jan 17, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants