Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to configtx.yaml to enable it to work as intended with the test network and channel tutorials #1185

Closed
wants to merge 5 commits into from

Conversation

schrodingerscode
Copy link

It seems the profile name was incorrectly changed to from "TwoOrgsApplicationGenesis" as the fabric tutorial requires to "ChannelUsingRafts". This latter profile name creates an error when setting up channels using the test network and tutorials. This update changes the profile name back to "TwoOrgsApplicationGenesis" as is required for the test network tutorials for which this file was created.

It seems the profile name was incorrectly changed to from "TwoOrgsApplicationGenesis" as the fabric tutorial requires to "ChannelUsingRafts".  This latter profile name creates an error when setting up channels using the test network and tutorials.  This update changes the profile name back to "TwoOrgsApplicationGenesis" as is required for the test network tutorials for which this file was created.

Signed-off-by: Ken P <[email protected]>
@schrodingerscode schrodingerscode requested a review from a team as a code owner March 19, 2024 15:37
@denyeart
Copy link
Contributor

denyeart commented Mar 19, 2024

We were going to evolve to "ChannelUsingRaft", but the doc pull request hyperledger/fabric#4528 never got merged because the commit wasn't signed. I'm fine going back to "TwoOrgsApplicationGenesis", but please grep fabric-samples for "ChannelUsingRaft" and update all occurrences so that we are consistent, which is necessary for the tests to pass.

…s' to enable it to work with test-network tutorial.

Signed-off-by: Ken P <[email protected]>
…s' to enable it to work with test-network tutorial.

Signed-off-by: Ken P <[email protected]>
…s' to enable it to work with test-network tutorial.

Signed-off-by: Ken P <[email protected]>
…s' to enable it to work with test-network tutorial.

Signed-off-by: Ken P <[email protected]>
@schrodingerscode
Copy link
Author

Ok. I have made the same update to all 5 (4 additional) instances that grep returned. Specifically, each instance of "ChannelUsingRafts" was changed back to "TwoOrgsApplicationGenesis".

@denyeart
Copy link
Contributor

denyeart commented Apr 3, 2024

@schrodingerscode @satota2 The doc changes to shift to "ChannelUsingRaft" have finally been merged in hyperledger/fabric#4781 and hyperledger/fabric#4788, so let's keep fabric-samples using "ChannelUsingRaft". I'll close this PR.

@denyeart denyeart closed this Apr 3, 2024
@schrodingerscode
Copy link
Author

Sounds good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants