Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TESTING] disable flaky fast sync actions test #8208

Merged
merged 5 commits into from
Feb 4, 2025
Merged

[TESTING] disable flaky fast sync actions test #8208

merged 5 commits into from
Feb 4, 2025

Conversation

macfarla
Copy link
Contributor

PR description

Fast sync is broken per #7511 - this test is flaky and unlikely to be fixed

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • spotless: ./gradlew spotlessApply
  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@macfarla
disable fast sync actions test
3002185 
Signed-off-by: Sally MacFarlane <[email protected]>
@macfarla macfarla added flake 60% of the time it works 100% of the time. testing labels Jan 31, 2025
pinges
pinges approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@pinges pinges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macfarla macfarla enabled auto-merge (squash) February 4, 2025 05:26
@macfarla macfarla merged commit e006bbf into hyperledger:main Feb 4, 2025
43 checks passed
pullurib pushed a commit to pullurib/besu that referenced this pull request Feb 6, 2025
@macfarla
[TESTING] disable flaky fast sync actions test (hyperledger#8208)
bfb5ba3 
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Bhanu Pulluri <[email protected]>
@macfarla macfarla deleted the disable-fast-sync-actions-test branch February 7, 2025 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinges pinges pinges approved these changes

Assignees
No one assigned
Labels
flake 60% of the time it works 100% of the time. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macfarla @pinges