Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TLS/mTLS options for websockets #7854

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add TLS/mTLS options for websockets #7854

wants to merge 4 commits into from

Conversation

pullurib
Copy link
Contributor

@pullurib pullurib commented Nov 4, 2024

  • Added options to set keystore path, password and type for TLS
  • Added options to set trust store path, password and type for mTLS
  • Added test cases

Fixes #1165

fab-10
fab-10 reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the contribution, please add a CHANGELOG entry.

@fab-10 fab-10 added the doc-change-required Indicates an issue or PR that requires doc to be updated label Nov 5, 2024
@fab-10
Copy link
Contributor

fab-10 commented Nov 5, 2024

This test is failing

BesuCommandTest > tomlThatConfiguresEverythingExceptPermissioningToml() FAILED
    java.lang.AssertionError at BesuCommandTest.java:430

@pullurib
Copy link
Contributor Author

pullurib commented Nov 7, 2024

@fab-10 Thanks for looking into it. Fixed and verified the failing test. Also added a PEM testcase and option dependencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fab-10 fab-10 fab-10 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
doc-change-required Indicates an issue or PR that requires doc to be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for custom keystore for secure websocket api.
2 participants
@pullurib @fab-10