Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/preimage store #7800

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

garyschulte
Copy link
Contributor

PR description

Draft status PR for preimage store.

Highlights include:

  • cli feature param
  • forest persisted or in-memory preimages store
  • bonsai persisted, in-memory limited, in-memory unbounded preimage store
  • refactoring, removing of reference test specific behavior
  • incorporation into worldstatekeyvaluestorage classes

📝 Draft status,
✅ reference tests passing

still outstanding TODOs:

  • specific unit test coverage
  • bonsai persistence version worked into worldstate composed storage
  • storage lazy initialization (forest),
  • correct/clean instantiation (bonsai)

Fixed Issue(s)

fixes #7796

Thanks for sending a pull request! Have you done the following?

  • Checked out our contribution guidelines?
  • Considered documentation and added the doc-change-required label to this PR if updates are required.
  • Considered the changelog and included an update if required.
  • For database changes (e.g. KeyValueSegmentIdentifier) considered compatibility and performed forwards and backwards compatibility tests

Locally, you can run these tests to catch failures early:

  • unit tests: ./gradlew build
  • acceptance tests: ./gradlew acceptanceTest
  • integration tests: ./gradlew integrationTest
  • reference tests: ./gradlew ethereum:referenceTests:referenceTests

@garyschulte garyschulte force-pushed the feature/preimage-store branch 13 times, most recently from 95eba10 to 6f04716 Compare October 24, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Implement hash preimage storage persistence
1 participant