Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: #1090 DID:SOV DIDDoc resolves without a service/endpoint #1096

Conversation

lukewli-anonyome
Copy link
Contributor

This PR introduces a fix for the DIDDoc resolution error outlined in issue #1090.

Closes #1090

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (40e9a87) 0.05% compared to head (a80a396) 0.05%.

❗ Current head a80a396 differs from pull request most recent head aa54000. Consider uploading reports for the commit aa54000 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1096   +/-   ##
=====================================
  Coverage   0.05%   0.05%           
=====================================
  Files        471     471           
  Lines      24109   24109           
  Branches    4336    4336           
=====================================
  Hits          13      13           
  Misses     24095   24095           
  Partials       1       1           
Flag Coverage Δ
unittests-aries-vcx 0.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukewli-anonyome lukewli-anonyome changed the title [DRAFT] Fix: #1090 DID:SOV DIDDoc resolves without a service/endpoint Fix: #1090 DID:SOV DIDDoc resolves without a service/endpoint Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DID:SOV DIDDoc does resolve without a service/endpoint
2 participants