Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version check for node warnings #516

Merged
merged 2 commits into from
Jul 27, 2023

Conversation

selvaprakash92
Copy link
Contributor

Type of change

  • Improvement (improvement to code, performance, etc)

Description

Signed-off-by: selvaprakash92 <[email protected]>
@selvaprakash92 selvaprakash92 requested a review from a team as a code owner July 25, 2023 13:18
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes needed, otherwise looks good

packages/apollo/src/assets/i18n/en/messages.json Outdated Show resolved Hide resolved
packages/apollo/src/components/PeerModal/PeerModal.js Outdated Show resolved Hide resolved
Copy link
Contributor

@dshuffma-ibm dshuffma-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks

@dshuffma-ibm dshuffma-ibm merged commit 594d5ec into hyperledger-labs:main Jul 27, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants