Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an way for complete specifying the peer crypto configurations when creating a new peer using the collection. #75

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

davidfdr
Copy link
Contributor

The parameters "crypto" and "certificate_authority" are mutual exclusive. So, if we provide the crypto configuration, we will have an error when the playbook tries to resolve the CA configuration because the CA name can't be provided using "certificate_authority" parameter.

The changes are:

  1. When "crypto" is provided, the ansible will use all provided information and won´t try to retrieve the ca using the name provided on "certificate_authority" parameter.
  2. Added new example for peer configuration playbook.

@davidfdr davidfdr changed the title Adding an way for complete specifying the crypto parameter. Adding an way for complete specifying the peer crypto configurations when creating a new peer using the collection. Oct 15, 2024
@fernandobsb
Copy link

great contribution, nice job! Congrats @davidfdr

Copy link
Contributor

@mbwhite mbwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for contributing.

@mbwhite mbwhite merged commit c7cd5e4 into hyperledger-labs:main Oct 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants