Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: components dedup #320

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

chore: components dedup #320

wants to merge 11 commits into from

Conversation

Xaroz
Copy link
Contributor

@Xaroz Xaroz commented Nov 11, 2024 •
edited
Loading

Needs #4847 and #4852 from monorepo

  • Remove and update components with the new changes from widgets lib
  • Use modal from widgets lib
  • Use IconButton from widgets lib
  • Removed Spinner and replaced with widgets lib

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024

@Xaroz is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

jmrossy
jmrossy reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress!
Please also de-dupe the Spinner and more of the SVG files under /src/images/

src/components/layout/Modal.tsx Outdated Show resolved Hide resolved
@Xaroz Xaroz changed the title Chore/components dedup chore: components dedup Nov 12, 2024
@Xaroz Xaroz requested a review from jmrossy November 12, 2024 21:26
jmrossy
jmrossy reviewed Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excited to remove all this stuff!

src/features/wallet/SideBarMenu.tsx Outdated Show resolved Hide resolved
@Xaroz Xaroz requested a review from jmrossy November 13, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot Awaiting requested review from nambrot nambrot is a code owner

@jmrossy jmrossy Awaiting requested review from jmrossy jmrossy is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xaroz @jmrossy