Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): artifacts symbol for warp deploy and update registry packages #5212

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

Xaroz
Copy link
Contributor

@Xaroz Xaroz commented Jan 20, 2025

Description

Fixes #5164

Fixed an issue where symbols were not taken into account when creating artifacts through warp deploy.

Drive-by changes

Update registry packages

Related issues

Related issue: registry fix

Backward compatibility

Yes

Testing

CLI
Manual

Copy link

changeset-bot bot commented Jan 20, 2025

🦋 Changeset detected

Latest commit: 3739b80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@hyperlane-xyz/cli Minor
@hyperlane-xyz/ccip-server Minor
@hyperlane-xyz/github-proxy Minor
@hyperlane-xyz/helloworld Minor
@hyperlane-xyz/infra Minor
@hyperlane-xyz/sdk Minor
@hyperlane-xyz/utils Minor
@hyperlane-xyz/widgets Minor
@hyperlane-xyz/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Xaroz Xaroz requested a review from xeno097 January 20, 2025 16:05
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (123d3ca) to head (3739b80).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5212   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@Xaroz Xaroz added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 228f7c3 Jan 20, 2025
42 checks passed
@Xaroz Xaroz deleted the fix/symbol-warp-deploy-artifact branch January 20, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Hyperlane Warp Deploy not creating file with correct symbol
2 participants