feat: FuelVM support for Hyperlane #4861

Mantas-M · 2024-11-15T10:33:56Z

Description

Support FuelVM chains on the Hyperlane Protocol
Configurations for FuelTestnet and FuelIgnition

Backward compatibility

Yes

Testing

Contract repo E2E testing on local Fuel and EVM nodes
Contract repo E2E testing on Fuel Testnet and Base Sepolia

Notes

The configurations for the Fuel Testnet and Ignition are still WIP

…structure/hyperlane-monorepo into feat/fuel-integration

…to latest

…onfigs

changeset-bot · 2024-11-15T10:34:00Z

⚠️ No Changeset found

Latest commit: 1eeffaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

codecov · 2024-11-18T11:35:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (11cf66c) to head (30b898f).
Report is 21 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4861   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21

Components	Coverage Δ
core	`87.80% <ø> (ø)`
hooks	`79.39% <ø> (ø)`
isms	`83.68% <ø> (ø)`
token	`91.27% <ø> (ø)`
middlewares	`79.80% <ø> (ø)`

aroralanuk

I left some comments; e2e as part of this PR will be necessary for approval but shouldn't be a blocker for audit.

aroralanuk · 2025-01-24T11:14:34Z

rust/main/chains/hyperlane-fuel/src/indexer/events.rs

+}
+
+// Implement `EventDataTransformer` for `GasPaymentEvent`
+impl EventDataTransformer for GasPaymentEvent {


These implementations all look identical, is it possible to make them more generic?

aroralanuk · 2025-01-24T11:26:52Z

rust/main/chains/hyperlane-fuel/src/indexer/query/conversions.rs

+// These conversions are the `From` implementations for converting the `Receipt` schema from the Fuels Rust SDK
+// since we cannot implement `From` for our custom Recipt schema on the `fuels::tx::Receipt` directly.
+
+pub fn generate_receipt(schema: Receipt) -> Result<FuelRecepit, ConversionError> {


kinda suprised there's no library for this code?

nit: FuelRecepit spelling

Spelling fixed

No library as from what I've seen, the types are ripped from the FuelSDK and redone since the types they have do not support all the GraphQL operations that are used to make the indexer optimized. The only supported ones are the ones which the SDK exposes as functions and chaining those together to make the indexer work is very inefficient.

Even though this code is quite ugly, it allows us to index Fuel using a single query, which is great for not spamming RPC requests.

aroralanuk · 2025-01-24T11:29:46Z

rust/main/chains/hyperlane-fuel/src/indexer/query/conversions.rs

+                    .into(),
+            ),
+            pc: schema
+                .pc


out of curosity, what's pc here - program counter?

It is a hexadecimal string representation of a 64-bit unsigned integer; value of register $pc.

aroralanuk · 2025-01-24T13:39:30Z

rust/main/chains/hyperlane-fuel/src/interchain_gas.rs

+}
+
+impl FuelInterchainGasPaymaster {
+    /// Create a new fuel validator announce contract


validator announce?

Updated ✅

aroralanuk · 2025-01-27T07:55:10Z

rust/main/chains/hyperlane-fuel/src/indexer/query/types.rs

+#[cynic::schema("fuel")]
+mod schema {}
+
+// The following macros and conversions are copied from the Fuels Rust SDK


can we not import this?

It's needed for the schema builder

aroralanuk · 2025-01-27T08:32:54Z

rust/main/chains/hyperlane-fuel/src/mailbox.rs

            .with_tx_policies(tx_policies)
-            .determine_missing_contracts(Some(3))
+            .determine_missing_contracts(Some(10))


can we make 10 a constant as max reattempts globally

Conveniently, that is the default is we pass in None
Updated ✅

aroralanuk · 2025-01-27T08:51:01Z

rust/main/chains/hyperlane-fuel/src/merkle_tree_hook.rs

+            .tree()
+            .simulate(Execution::StateReadOnly)
+            .await
+            .map_err(ChainCommunicationError::from_other)


from_other_str

Verbose errors across the board

aroralanuk · 2025-01-27T08:51:17Z

rust/main/chains/hyperlane-fuel/src/merkle_tree_hook.rs

+            .count()
+            .simulate(Execution::StateReadOnly)
+            .await
+            .map_err(ChainCommunicationError::from_other)


Verbose errors across the board

aroralanuk · 2025-01-27T10:22:55Z

rust/main/hyperlane-base/src/settings/base.rs

@@ -81,6 +82,20 @@ impl Settings {
            .ok_or_else(|| eyre!("No chain setup found for {domain}"))
    }

+    /// Check and warn if reorg period is set for FuelVM domains.
+    pub fn check_fuel_reorg(&self) {


not sure why you need this? we can just ignore the param

This was suggested to be added by @daniel-savu, the param is ignored, just adds a warning that the config has an invalid value

aroralanuk · 2025-01-27T10:26:53Z

rust/main/chains/hyperlane-fuel/src/aggregation_ism.rs

+    pub async fn new(
+        conf: &ConnectionConf,
+        locator: ContractLocator<'_>,
+        mut wallet: WalletUnlocked,


Wallet (readonly) seems sufficient in a lot of these places or is WalletUnlocked just for consistency?

Consistency mostly, since we need an unlocked wallet anyway, it's cleaner to manage only one instance instead of using one for reads and one for writes

Mantas-M and others added 23 commits October 2, 2024 10:58

feat(fuel-integratin): initial integration

1c33345

Merge remote-tracking branch 'origin' into feat/fuel-integration

c7cf165

Merge branch 'hyperlane-xyz:main' into feat/fuel-integration

eb0acba

Merge branch 'hyperlane-xyz:main' into feat/fuel-integration

4cf4f35

fix(indexer): constant cursor updates, is_contract_call fix

1a9555d

Merge remote-tracking branch 'origin' into feat/fuel-integration

39a7484

Merge branch 'feat/fuel-integration' of https://github.com/fuel-infra…

828fe6a

…structure/hyperlane-monorepo into feat/fuel-integration

feat(indexer): make generic, reduce boilerplate

a24439f

Merge branch 'hyperlane-xyz:main' into feat/fuel-integration

9a31877

fix(fuel): small mailbox and ism tweaks

10aa248

fix(mailbox): gas estimation issues

6bbcdae

feat(mailbox): add buffer to gas estimation

3b4ea46

fix(warp-routes): add wr message indexer temp workaround

1f310b4

fix(warp-routes): with_variable_output_policy during process call

795956a

feat(fuel-integration): minor contract interface updates, bump fuels …

833f32c

…to latest

feat(fuel-integration): fuel contract interface updates from the demos

fe93d23

chore(fuel-integration): add todo for the MerkleTreeHook Fix

9988d2c

feat(fuel-integration): indexer upgrade

ef6c739

feat(merkle): merkle tree hook with enforced finality

edc077d

feat(fuel-integration): clippy fixes

edb0b62

chore(fuel-provider): decrease nesting

e07d0cd

feat(fuel-integration): merge conflicts

2ee0ddc

feat(fuel-integration): add FuelIgnition chain, WIP mainnet/testnet c…

45cc4d2

…onfigs

Mantas-M requested review from tkporter and daniel-savu as code owners November 15, 2024 10:33

Mantas-M added 3 commits November 18, 2024 13:20

chore(fue-integration): spelling error in comment

4d91002

chore(fue-integration): remove useless &

b649fa9

feat(fuelvm-integration): reorg logic

1e43076

Mantas-M added 5 commits November 25, 2024 18:45

fix(fuel-integration): configs and get finalized block fn

151ead8

feat(scraper): FuelVM support

ca463ea

Merge remote-tracking branch 'origin' into feat/fuel-integration

cb03cf0

fix(merge): conflicts

de81f39

fix(merge): conflicts

30b898f

aroralanuk reviewed Jan 27, 2025

View reviewed changes

Mantas-M added 8 commits January 30, 2025 10:01

feat(fuel-integration): fuel contract abi updates

68562f1

chore(fuel-indexer-events): generic event data transformer impl

bec5645

chore(comment): va -> igp comment update

3c753e7

chore(comment): ism comment update

bc69993

fix(contract-calls): use default for determine missing contracts

e9e419d

chore(spelling): Receipt

1e7be59

chore(errors): make errors more verbose

04dac6f

fix(clippy): resolve clippy errors

1eeffaf

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: FuelVM support for Hyperlane #4861

feat: FuelVM support for Hyperlane #4861

Mantas-M commented Nov 15, 2024

changeset-bot bot commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading

aroralanuk left a comment

aroralanuk Jan 24, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 24, 2025

aroralanuk Jan 24, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 24, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 24, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

aroralanuk Jan 27, 2025

Mantas-M Jan 31, 2025

feat: FuelVM support for Hyperlane #4861

Are you sure you want to change the base?

feat: FuelVM support for Hyperlane #4861

Conversation

Mantas-M commented Nov 15, 2024

Description

Backward compatibility

Testing

Notes

changeset-bot bot commented Nov 15, 2024 • edited Loading

⚠️ No Changeset found

codecov bot commented Nov 18, 2024 • edited Loading

Codecov Report

aroralanuk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

changeset-bot bot commented Nov 15, 2024 •

edited

Loading

codecov bot commented Nov 18, 2024 •

edited

Loading