Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): enable HypFiatCollateral warp route deployments #3952

Closed
wants to merge 5 commits into from
Closed

feat(cli): enable HypFiatCollateral warp route deployments #3952

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2c70670
fix: enable HypFiatCollateral warp route deployments
AlexBHarley Jun 12, 2024
bb32968
chore: changeset
AlexBHarley Jun 12, 2024
611237d
Merge branch 'main' into alexbharley/hypfiatcollateral-warp-route
AlexBHarley Jun 13, 2024
62828ba
chore: document todo
AlexBHarley Jun 13, 2024
7cb2d10
Merge branch 'main' into alexbharley/hypfiatcollateral-warp-route
AlexBHarley Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/modern-pianos-accept.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperlane-xyz/cli': patch
---

Enable HypFiatCollateral warp route deployments
6 changes: 5 additions & 1 deletion typescript/cli/src/deploy/warp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ async function getWarpCoreConfig(
}

const collateralAddressOrDenom =
config.type === TokenType.collateral ? config.token : undefined;
// todo: should this match typescript/cli/src/config/warp.ts line 136?
config.type === TokenType.collateral ||
config.type == TokenType.collateralFiat
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @ltyu added a list recently that would be helpful here: https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/3838/files#diff-a1429ad1c3e9d3fe43d28f08333e95f6c79176b6d36873e42e455e5e806826aaR16

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmrossy what's the timeline for CLI 2.0, or are people already trying it out?

Could do this branch on top of that if we prefer. Otherwise a TODO seems appropriate

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO is fine
will followup when we are merging CLI 2.0, hopefully in a couple days

? config.token
: undefined;
warpCoreConfig.tokens.push({
chainName,
standard: TOKEN_TYPE_TO_STANDARD[config.type],
Expand Down
Loading