Cosmos gas price config #3042
Merged
Cosmos gas price config #3042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tkporter
reviewed
Dec 12, 2023
tkporter
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Realizing that we'll need to change the typescript SDK too to keep things consistent
I think we need:
- a gas price property like we've done for other cosmos chain metadata properties here https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/sdk/src/metadata/chainMetadataTypes.ts#L168
- add the property to the refine here to make sure it's specified for cosmos chains https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/sdk/src/metadata/chainMetadataTypes.ts#L206
- add the gas prices for the cosmos chains here https://github.com/hyperlane-xyz/hyperlane-monorepo/blob/main/typescript/sdk/src/consts/chainMetadata.ts
daniel-savu
force-pushed
the
dan/cosmos-gas-price-config
branch
from
4e41e90
to
781cc79
Compare
daniel-savu
requested review from
Skunkchain,
nambrot and
avious00
as code owners
yorhodes
pushed a commit
that referenced
this pull request
Dec 20, 2023
### Description Adds a cosmos-specific config item for setting the minimum gas price, in the format returned by the `cosmos.base.node.v1beta1.Service/Config` cosmos-sdk grpc endpoint. ### Related issues - Fixes hyperlane-xyz/issues#810 ### Backward compatibility No. Will break existing cosmos configs. ### Testing None yet, will test in e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a cosmos-specific config item for setting the minimum gas price, in the format returned by the
cosmos.base.node.v1beta1.Service/Configcosmos-sdk grpc endpoint.Related issues
Backward compatibility
No. Will break existing cosmos configs.
Testing
None yet, will test in e2e