Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make mailbox client upgrade safe #2984

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Make mailbox client upgrade safe #2984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aa3d6a5
Add gap back to MailboxClient
0xmichalis Nov 9, 2023
0fd47ec
Merge branch 'main' into toucan/mailbox-client-upgrade-safe
yorhodes Nov 28, 2023
63a2d0c
Add changeset
yorhodes Nov 28, 2023
bcd1c3e
Merge branch 'main' into toucan/mailbox-client-upgrade-safe
yorhodes Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/hip-jobs-smoke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@hyperlane-xyz/core': minor
---

Includes storage gap in Mailbox Client for forwards compatibility
2 changes: 2 additions & 0 deletions solidity/contracts/client/MailboxClient.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ abstract contract MailboxClient is OwnableUpgradeable {

IInterchainSecurityModule public interchainSecurityModule;

uint256[48] private __GAP; // gap for upgrade safety

// ============ Modifiers ============
modifier onlyContract(address _contract) {
require(
Expand Down
Loading