Add gap back to MailboxClient #2904
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gap should ensure MailboxClient is upgrade-safe as long as future additions to the contract reduce the gap properly.
0xmichalis
requested review from
yorhodes,
tkporter and
aroralanuk
as code owners
|
Would be super grateful if y'all can keep these contracts safely upgradeable in future! 🙏 |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v3 #2904 +/- ##
==========================================
+ Coverage 62.53% 68.04% +5.50%
==========================================
Files 99 99
Lines 1017 1017
Branches 106 106
==========================================
+ Hits 636 692 +56
+ Misses 344 286 -58
- Partials 37 39 +2
|
|
pulled in to #2984 |
yorhodes
added a commit
that referenced
this pull request
Nov 28, 2023
### Description Pulls in changes from #2904 ### Related issues - Fixes hyperlane-xyz/issues#593 ### Backward compatibility No, existing v3 MailboxClients (Routers) will be storage incompatible ### Testing Unit Tests --------- Co-authored-by: Michalis Kargakis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gap should ensure MailboxClient is
upgrade-safe as long as future additions
to the contract reduce the gap properly.