Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating IGP as a hook #2600

Closed
wants to merge 19 commits into from
Closed

Integrating IGP as a hook #2600

wants to merge 19 commits into from

Conversation

aroralanuk
Copy link
Contributor

  • op hook v2
  • optimismhook v3
  • remove msg.sender
  • pass msgvalue as metadata
  • workflow enabled for non-main merge
  • update solidity version icrossdomainmessenger
  • move verifyMessageId to abstractHookISM
  • nameChangeToAbstractMessageIdAuthorizedIsm
  • isAuthorized returns bool
  • igp backward compatible
  • igp hook standalone

Description

  • IGP as a standalone hook, implementing _postDispatch to call payForGas directly
  • Setting a DEFAULT_GAS_USAGE if metadata not specified and message.senderAddress() as refund address if not specified.

Drive-by changes

  • Uses a single GasOracle

Related issues

Fixes https://github.com/hyperlane-xyz/issues/issues/511

Backward compatibility

Yes, same interface as the previous IGP but for Mailbox V3

Testing

None

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v3@8cabf55). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 2b4ea86 differs from pull request most recent head b2207eb. Consider uploading reports for the commit b2207eb to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##             v3    #2600   +/-   ##
=====================================
  Coverage      ?   59.78%           
=====================================
  Files         ?      101           
  Lines         ?     1512           
  Branches      ?      216           
=====================================
  Hits          ?      904           
  Misses        ?      601           
  Partials      ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aroralanuk aroralanuk closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant