-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hyperlane Warp Deploy not creating file with correct symbol #5164
Comments
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-registry
that referenced
this issue
Jan 17, 2025
### Description <!-- Summary of change. Example: Add sepolia chain --> This PR along with a PR to the monorepo aims to fix the artifacts for warp route deployments by taking into account the symbol field, mentioned in [this issue](hyperlane-xyz/hyperlane-monorepo#5164) - Add `WarpRouteOptions` as optional parameter to `addWarpRoute` - Change `getWarpRouteArtifactPaths` to receive a `symbol` as the folder path - Include unit test ### Backward compatibility <!-- Are these changes backward compatible? Note that additions are backwards compatible. Yes/No --> Yes ### Testing <!-- Have any new metadata configs and deployment addresses been used with any Hyperlane tooling, such as the CLI? --> CLI
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 20, 2025
…es (#5212) ### Description <!-- What's included in this PR? --> Fixes #5164 Fixed an issue where symbols were not taken into account when creating artifacts through warp deploy. ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> Update registry packages ### Related issues <!-- - Fixes #[issue number here] --> Related issue: [registry fix](hyperlane-xyz/hyperlane-registry#499) ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> Yes ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests --> CLI Manual
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Is your feature request related to a problem? Please describe.
When running
hyperlane warp deploy
where the resulting synthetic token symbol is different from the collateral one, it will spit out a.config-yaml
file that does not contain the correct symbol, but the resulting token is still correctAdditional context
Issue happened when trying to do
hyperlane warp deploy
frombase USDC
toartela USDC.a
:After running the command it spits the following config.yaml file:
But if you check the contract itself, it will show that deploy was done correctly in the correct symbol: https://artscan.artela.network/token/0x8d9Bd7E9ec3cd799a659EE650DfF6C799309fA91
Solution
Describe the solution you'd like
The
hyperlane warp deploy
command should spit a config file with the correct symbolsDescribe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Nice to Have
Describe non-essential extensions to the solution
Additional features which should be implemented if they are easy to accommodate but otherwise can be skipped
The text was updated successfully, but these errors were encountered: