Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace use tooltip instead of toast for show tip information #67

Conversation

tiendn
Copy link

@tiendn tiendn commented Apr 24, 2024

We should use tooltips to display tip information instead of Toasts.

Reasons:

  • Users have to shift their focus from the current help area to the bottom right corner, resulting in poor user experience. It becomes unclear which help was hovered over after moving the mouse.
  • Toasts have a delay that is too long and are limited to a maximum of two. Even when moving to another location or page, they still appear and continue to display if clicked multiple times.

Solution:

  • Implement tooltips using react-tooltip.
  • Remove the onClick event and display tooltips instead of Toasts.

I have some demo videos here:
Before:

Screen.Recording.2024-04-24.at.23.26.36.mov

After:

Screen.Recording.2024-04-24.at.23.27.22.mov

Copy link

vercel bot commented Apr 24, 2024

Someone is attempting to deploy a commit to the Abacus Works Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@jmrossy jmrossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! Just a few minor tweaks needed

src/pages/_app.tsx Outdated Show resolved Hide resolved
src/components/icons/HelpIcon.tsx Outdated Show resolved Hide resolved
src/components/icons/HelpIcon.tsx Outdated Show resolved Hide resolved
@tiendn
Copy link
Author

tiendn commented Apr 29, 2024

Thanks @jmrossy.
I've updated

@jmrossy jmrossy changed the base branch from main to tooltip April 29, 2024 14:08
@jmrossy jmrossy merged commit cddb2d8 into hyperlane-xyz:tooltip Apr 29, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants