Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select rows, one by one #18

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Select rows, one by one #18

merged 6 commits into from
Jan 7, 2025

Conversation

severo
Copy link
Contributor

@severo severo commented Jan 6, 2025

Screencast.From.2025-01-06.23-59-18.webm

The selected rows are in the dispatched state, as an array of ranges: selection: {start: number, end: number}[].

We show a checkbox when hovering the row number, or when a row is selected. Same behavior as Airtable.

Next steps:

  • add a checkbox in the top left cell (instead of the hyperparam logo) to select/unselect all the rows
  • select/unselect multiple rows with shift+click
  • select/unselect multiple rows with drag/drop on the checkboxes?

@severo severo marked this pull request as draft January 6, 2025 17:09
@severo severo changed the title create Selection type Select rows, one by one Jan 6, 2025
@severo severo requested a review from platypii January 6, 2025 22:56
@severo severo marked this pull request as ready for review January 6, 2025 22:56
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 😍

@severo severo merged commit ff3ca03 into master Jan 7, 2025
8 checks passed
@severo severo deleted the select-multiple-rows branch January 7, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants