Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass MouseEvent to onDoubleClickCell #14

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

platypii
Copy link
Contributor

This change makes onDoubleClickCell consistent with onMouseDownCell by passing the React.MouseEvent as the first argument. This is helpful because sometimes you want access to the mouse event, either to get more info, or potentially prevent default, etc.

BREAKING CHANGE: Any packages that depend on hightable and use onDoubleClickCell needs to change their type signature! When published this needs to be hightable v0.8.0.

@platypii platypii requested a review from severo December 16, 2024 17:43
@platypii platypii merged commit db92af3 into master Dec 16, 2024
8 checks passed
@platypii platypii deleted the onDoubleClick-event branch December 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants