Skip to content

Commit

Permalink
improve comment
Browse files Browse the repository at this point in the history
  • Loading branch information
severo committed Jan 14, 2025
1 parent 7d138f6 commit 00c80d1
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/dataframe.ts
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,8 @@ export function sortableDataFrame(data: DataFrame): DataFrame {
rows(start: number, end: number, orderBy?: string): AsyncRow[] | Promise<Row[]> {
if (orderBy) {
if (!data.header.includes(orderBy)) {
/// TODO(SL): should we allow '__index__'?
// '__index__' is not allowed, and it would not make sense anyway
// as it's the same as orderBy=undefined, since we only support ascending order
throw new Error(`Invalid orderBy field: ${orderBy}`)
}
if (!all) {
Expand Down

0 comments on commit 00c80d1

Please sign in to comment.