-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atomics support in the standard library #1637
base: main
Are you sure you want to change the base?
Conversation
This way, we know more about what failed, and not get just "exception".
@kyouko-taiga : Do you have any idea why I get a "Sources/FrontEnd/TypeChecking/TypeChecker.swift:6183: Assertion failed: type already inferred" error on many of the tests on Ubuntu builds (see https://github.com/hylo-lang/hylo/actions/runs/12597537109/job/35110729555?pr=1637)? |
It means something causes the type checker to visit the same tree twice. If you point me at the test cases that are failing I can investigate if you want. |
The failures can be seen at https://github.com/hylo-lang/hylo/actions/runs/12597537109/job/35110729555?pr=1637.
Please note that these tests only fail on Ubuntul, I haven't seen any failures on MacOS. |
If the failure is so widespread I think there's something going wrong with your code generator. It's surprising that the error occurs only on Ubuntu but perhaps that's because you're generating a duplicate declaration only on this platform? My current theory is that two identical definitions are being fed to the type checker (which currently does not check for duplicate declaration). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1637 +/- ##
==========================================
+ Coverage 88.34% 88.76% +0.42%
==========================================
Files 381 381
Lines 31503 31503
==========================================
+ Hits 27831 27964 +133
+ Misses 3672 3539 -133 ☔ View full report in Codecov by Sentry. |
No description provided.