Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Validate multi-ticker pandas arguments #263

Merged
merged 4 commits into from
May 5, 2019

Conversation

hydrosquall
Copy link
Owner

@hydrosquall hydrosquall commented Apr 30, 2019

Summary of Changes

Checklist

  • Code follows the style guidelines of this project
  • Added tests for new functionality
  • Update HISTORY.rst with an entry summarizing your change
  • Tag a project maintainer

@hydrosquall hydrosquall self-assigned this Apr 30, 2019
@hydrosquall hydrosquall force-pushed the feature/validate-multi-ticker-pandas-arguments branch 2 times, most recently from 5b92b42 to e5e298d Compare April 30, 2019 03:40
@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   96.64%   96.73%   +0.09%     
==========================================
  Files           4        5       +1     
  Lines         179      184       +5     
==========================================
+ Hits          173      178       +5     
  Misses          6        6
Impacted Files Coverage Δ
tiingo/api.py 96.64% <100%> (-0.07%) ⬇️
tiingo/exceptions.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bb98ca...e5e298d. Read the comment docs.

@codecov
Copy link

codecov bot commented Apr 30, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   96.64%   96.73%   +0.09%     
==========================================
  Files           4        5       +1     
  Lines         179      184       +5     
==========================================
+ Hits          173      178       +5     
  Misses          6        6
Impacted Files Coverage Δ
tiingo/api.py 96.64% <100%> (-0.07%) ⬇️
tiingo/exceptions.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e39b975...03e7b53. Read the comment docs.

@Kuhno92
Copy link

Kuhno92 commented Apr 30, 2019

This error message seems to be way more related to the actuall error. Good Job ;)

Nevertheless i would like to see a feature in the future to get all metrics from a list of tickers with a single api call.

Kind Regards
Kuhno92

@hydrosquall
Copy link
Owner Author

Hi @Kuhno92 ,

Thanks for chiming in. I'm going to merge this updated error message for now, and file an issue to consider adding this new method as a feature request. Would something like this code snippet work for your use case?

@hydrosquall hydrosquall force-pushed the feature/validate-multi-ticker-pandas-arguments branch from e5e298d to 03e7b53 Compare May 5, 2019 19:43
@hydrosquall hydrosquall merged commit 762090b into master May 5, 2019
@hydrosquall hydrosquall deleted the feature/validate-multi-ticker-pandas-arguments branch October 17, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants