Skip to content

Commit

Permalink
moved the continue-on-error: true to the job metadata
Browse files Browse the repository at this point in the history
  • Loading branch information
giumas committed Oct 20, 2024
1 parent e99d6de commit 449496a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/abc2_on_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on: [push]
jobs:
build:
runs-on: ubuntu-latest
continue-on-error: true
strategy:
max-parallel: 5

Expand Down Expand Up @@ -33,12 +34,10 @@ jobs:
flake8 ./hyo2/abc2 --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 ./hyo2/abc2 --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
continue-on-error: true
- name: Test with pytest
run: |
pip install coveralls PyYAML pytest pytest-cov
py.test --cov
coverage report -m
# disabled linux reports to avoid mixing with windows ones
# coveralls
continue-on-error: false
3 changes: 1 addition & 2 deletions .github/workflows/abc2_on_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on: [push]
jobs:
build:
runs-on: windows-latest
continue-on-error: true
strategy:
max-parallel: 5

Expand Down Expand Up @@ -33,11 +34,9 @@ jobs:
flake8 .\hyo2\abc2 --count --select=E9,F63,F7,F82 --show-source --statistics
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 .\hyo2\abc2 --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
continue-on-error: true
- name: Test with pytest
run: |
pip install coveralls PyYAML pytest pytest-cov
py.test --cov
coverage report -m
coveralls
continue-on-error: false

0 comments on commit 449496a

Please sign in to comment.