[Bugfix] VideoCaptureProperties being an int64 does not correctly unpack the parameters for OpenCV VideoCapture.open #1250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes the type of
VideoCaptureProperties
toint32
. It is currently set toint
. This breaksVideoCapture_OpenDeviceWithAPIParams
because it doesn't correclty unpack the slice into thestd::vector<int>
here:With
int64
this for loop will create only zeros in the value parts of the array that OpenCV expects ([p1, v1, ..., pn, vn]
).Changing it to
int32
unpacks the slice correctly and OpenCV will pass the parameters correctly to the respective VideoCapture backends.