Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code extentions recommendation #73

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# TODO: specify bump command and remove this description

Bump version workflow is triggered when PR is closed, it bumps version and triggers docker build that will be tagged with version number. To use it you have to specify bump type, available commands: `bump::patch`, `bump::minor` and `bump::major` (simply leave one of them in PR description and remove this description).
Bump version workflow is triggered when PR is closed, it bumps version and triggers docker build that will be tagged with version number. To use it you have to specify bump type, available commands: `bump::patch`, `bump::minor` and `bump::major` (simply leave one of them in PR description and remove this description).
2 changes: 1 addition & 1 deletion .github/workflows/bump_version.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,4 @@ jobs:
-H "Accept: application/vnd.github+json"
-H "Authorization: Bearer ${{ secrets.GH_PAT }}"
https://api.github.com/repos/husarion/rosbot-docker/dispatches
-d '{"event_type":"ros-package-update"}'
-d '{"event_type":"ros-package-update"}'
2 changes: 1 addition & 1 deletion .github/workflows/industrial_ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ jobs:
vcs import . < ./rosbot/rosbot_simulation.repos
- uses: ros-industrial/industrial_ci@master
env:
ROS_DISTRO: ${{matrix.ROS_DISTRO}}
ROS_DISTRO: ${{matrix.ROS_DISTRO}}
2 changes: 1 addition & 1 deletion .github/workflows/spellcheck.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
steps:
- uses: actions/checkout@v3
- uses: rojopolis/[email protected]
name: Spellcheck
name: Spellcheck
5 changes: 3 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
.vscode
*.pyc

# ROS 2 build folders
build
install
log
*.pyc

# ROSbots submodules
rosbot_hardware_interfaces/
Expand Down
2 changes: 1 addition & 1 deletion .pyspelling.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,4 +50,4 @@ matrix:
- .wordlist.txt

pipeline:
- pyspelling.filters.xml
- pyspelling.filters.xml
10 changes: 10 additions & 0 deletions .vscode/extensions.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"recommendations": [
"ms-iot.vscode-ros",
"ms-python.black-formatter",
"streetsidesoftware.code-spell-checker",
"kevinrose.vsc-python-indent",
"ms-python.python",
"shardulm94.trailing-spaces"
]
}
12 changes: 12 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"cSpell.customDictionaries": {
"project-words": {
"name": "Workspace Dictionary for Github Action",
"path": "${workspaceRoot}/.wordlist.txt",
"addWords": true
},
"custom": true,
"internal-terms": false
},
"files.insertFinalNewline": true
}
4 changes: 3 additions & 1 deletion .wordlist.txt
Original file line number Diff line number Diff line change
Expand Up @@ -117,4 +117,6 @@ Delicat
Jakub
Bence
Palacios
env
env
pids
pgrep
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ ros2 launch rosbot_gazebo simulation.launch.py
colcon test
```

> [!NOTE]
> [!NOTE]
> Command `colcon test` does not build the code. Remember to build your code after changes.

If tests finish with errors print logs:
Expand Down
2 changes: 1 addition & 1 deletion rosbot/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ project(rosbot)

find_package(ament_cmake REQUIRED)

ament_package()
ament_package()
2 changes: 1 addition & 1 deletion rosbot/rosbot_hardware.repos
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@ repositories:
rosbot_controllers:
type: git
url: https://github.com/husarion/rosbot_controllers
version: main
version: main
2 changes: 1 addition & 1 deletion rosbot_controller/config/mecanum_drive_controller.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -101,4 +101,4 @@ rosbot_base_controller:
# min_velocity - When unspecified, -max_velocity is used
max_acceleration: 4.0 # rad/s^2
# min_acceleration - When unspecified, -max_acceleration is used.
max_jerk: 0.0 # rad/s^3
max_jerk: 0.0 # rad/s^3
2 changes: 1 addition & 1 deletion rosbot_controller/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,4 +53,4 @@
<export>
<build_type>ament_python</build_type>
</export>
</package>
</package>
2 changes: 1 addition & 1 deletion rosbot_description/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ install(DIRECTORY
DESTINATION share/${PROJECT_NAME}
)

ament_package()
ament_package()
2 changes: 1 addition & 1 deletion rosbot_description/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
<export>
<build_type>ament_cmake</build_type>
</export>
</package>
</package>
2 changes: 1 addition & 1 deletion rosbot_description/urdf/body.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -85,4 +85,4 @@
<xacro:range_sensor.vl53lox parent="body_link" xyz="-0.0926 -0.05 0.0115" rpy="0.0 0.0 ${radians(192.5)}" prefix="rr" />

</xacro:macro>
</robot>
</robot>
2 changes: 1 addition & 1 deletion rosbot_description/urdf/components/vl53lox.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -49,4 +49,4 @@
</xacro:if>

</xacro:macro>
</robot>
</robot>
2 changes: 1 addition & 1 deletion rosbot_description/urdf/rosbot.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -24,4 +24,4 @@
rpy="0.0 0.0 0.0"
simulation_engine="$(arg simulation_engine)" />

</robot>
</robot>
2 changes: 1 addition & 1 deletion rosbot_description/urdf/rosbot_macro.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -206,4 +206,4 @@
</xacro:if>
</xacro:if>
</xacro:macro>
</robot>
</robot>
2 changes: 1 addition & 1 deletion rosbot_description/urdf/wheel.urdf.xacro
Original file line number Diff line number Diff line change
Expand Up @@ -105,4 +105,4 @@
</gazebo>

</xacro:macro>
</robot>
</robot>
2 changes: 1 addition & 1 deletion rosbot_gazebo/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,4 +40,4 @@
<export>
<build_type>ament_python</build_type>
</export>
</package>
</package>