Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test gazebo scan #71

Merged
merged 7 commits into from
Oct 16, 2023
Merged

Test gazebo scan #71

merged 7 commits into from
Oct 16, 2023

Conversation

delihus
Copy link
Contributor

@delihus delihus commented Sep 11, 2023 •
edited
Loading

bump::minor

@delihus delihus requested a review from macstepien September 11, 2023 10:21
@delihus
added scan test
473a6e2 
Signed-off-by: Jakub Delicat <[email protected]>
@rafal-gorecki rafal-gorecki changed the base branch from humble to test-gazebo October 3, 2023 15:30
@rafal-gorecki rafal-gorecki changed the base branch from test-gazebo to humble October 3, 2023 15:32
rafal-gorecki
rafal-gorecki requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@rafal-gorecki rafal-gorecki left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scan_event not used in test, additionally the validity of the test is also questionable, because Rosbot does not have an antenna in the mesh, so I don't know what is being checked there?

@delihus delihus marked this pull request as ready for review October 11, 2023 09:33
@delihus
Added tests to readme
23c5c83 
Signed-off-by: Jakub Delicat <[email protected]>
delihus and others added 2 commits October 16, 2023 07:38
@delihus delihus requested a review from rafal-gorecki October 16, 2023 05:39
@rafal-gorecki rafal-gorecki merged commit 186d98c into humble Oct 16, 2023
3 checks passed
@rafal-gorecki rafal-gorecki deleted the test-gazebo-scan branch October 16, 2023 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafal-gorecki rafal-gorecki rafal-gorecki approved these changes

@macstepien macstepien Awaiting requested review from macstepien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@delihus @rafal-gorecki