Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account changes fix #6854

Merged
merged 47 commits into from
Jun 14, 2024
Merged

Account changes fix #6854

merged 47 commits into from
Jun 14, 2024

Conversation

Zasa-san
Copy link
Collaborator

@Zasa-san Zasa-san commented Jun 3, 2024

PR checklist:

  • Update READ.me ?
  • Update API documentation ?

QA checklist:

  • Smoke test the functionality described in the issue
  • Test for side effects
  • UI responsiveness
  • Cross browser testing
  • Code review

@Zasa-san Zasa-san requested a review from fnocetti June 10, 2024 13:46
@Zasa-san Zasa-san marked this pull request as ready for review June 11, 2024 20:03
@Zasa-san Zasa-san requested a review from mfacar June 11, 2024 20:03
Copy link
Collaborator

@mfacar mfacar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Maybe it is intended but I noticed the following regarding the functionality.
On Users:

  • When the password is not valid, the side panel is closed, and it is necessary to open it again to continue the action, in the case of creating a user the form remains dirty, the edition however is reseting the values. It would be great, if it is possible to keep the side panel opened after the error, with the dirty fields for both cases.
  • Reset Password doesn't ask for the confirmation password, as I think it was agreed by the team, however, there is a pre existent validation error while applying the action on many users.

On Account:

  • The email field is also reset after a password error.

typos on submmitedPassword and worngPass

@Zasa-san
Copy link
Collaborator Author

When the password is not valid, the side panel is closed, and it is necessary to open it again to continue the action, in the case of creating a user the form remains dirty, the edition however is reseting the values. It would be great, if it is possible to keep the side panel opened after the error, with the dirty fields for both cases.

That's a good point. I will leave the sidepanel open when the password is incorrect. That way the user will not loose changes.

Reset Password doesn't ask for the confirmation password, as I think it was agreed by the team, however, there is a pre existent validation error while applying the action on many users.

If you are testing this with our e2e fixtures that happens because one of the users (editor) doesn't have an email. That's not possible to archive without manually manipulating the DB and removing the user email, since you can't create a user without an email.

The email field is also reset after a password error.

Will fix!

typos on submmitedPassword and worngPass

Thanks for the catch 👁️

@mfacar

@Zasa-san Zasa-san requested a review from mfacar June 13, 2024 15:54

useEffect(() => {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@konzz I'm not sure why this effect is here, since I can't find a problem with removing it. (Asking you since I think you added this initially)

@Zasa-san Zasa-san merged commit 88e7c2c into development Jun 14, 2024
13 of 15 checks passed
@Zasa-san Zasa-san deleted the 3.1.4-fix branch June 14, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants