-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Account changes fix #6854
Account changes fix #6854
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Maybe it is intended but I noticed the following regarding the functionality.
On Users:
- When the password is not valid, the side panel is closed, and it is necessary to open it again to continue the action, in the case of creating a user the form remains dirty, the edition however is reseting the values. It would be great, if it is possible to keep the side panel opened after the error, with the dirty fields for both cases.
- Reset Password doesn't ask for the confirmation password, as I think it was agreed by the team, however, there is a pre existent validation error while applying the action on many users.
On Account:
- The email field is also reset after a password error.
typos on submmitedPassword and worngPass
That's a good point. I will leave the sidepanel open when the password is incorrect. That way the user will not loose changes.
If you are testing this with our e2e fixtures that happens because one of the users (
Will fix!
Thanks for the catch 👁️ |
|
||
useEffect(() => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@konzz I'm not sure why this effect is here, since I can't find a problem with removing it. (Asking you since I think you added this initially)
PR checklist:
QA checklist: