Refactor PDF processing to remove thumbnail deletion and streamline f…

…ile saving
huridocs · Jan 17, 2025 · e33c1c6 · e33c1c6
1 parent 8dc35e4
commit e33c1c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/app/api/files/PDF.ts b/app/api/files/PDF.ts
@@ -80,10 +80,6 @@ class PDF extends EventEmitter {
     return Promise.resolve(response);
   }
 
-  async deleteThumbnail(filename: string) {
-    await storage.removeFile(filename, 'thumbnail');
-  }
-
   async convert() {
     return this.extractText().then(conversion => ({
       ...conversion,

diff --git a/app/api/files/processDocument.ts b/app/api/files/processDocument.ts
@@ -1,3 +1,4 @@
+/* eslint-disable max-statements */
 import { convertToPDFService } from 'api/services/convertToPDF/convertToPdfService';
 import settings from 'api/settings';
 import { FileType } from 'shared/types/fileType';
@@ -25,6 +26,12 @@ export const processPDF = async (
       conversion.language = file.language;
     }
 
+    const saved = await files.save({
+      ...upload,
+      ...conversion,
+      status: 'ready',
+    });
+
     thumbnail = await pdf.createThumbnail(upload._id.toString());
 
     await files.save({
@@ -35,18 +42,8 @@ export const processPDF = async (
       mimetype: 'image/jpeg',
     });
 
-    const saved = await files.save({
-      ...upload,
-      ...conversion,
-      status: 'ready',
-    });
-
     return saved;
   } catch (e) {
-    if (e.constructor === UpdateFileError) {
-      await pdf.deleteThumbnail(thumbnail);
-    }
-
     await files.save({
       ...upload,
       status: 'failed',