Set value + expiration in one trip #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems like an acceptable trade-off to make 👍 One fewer roundtrip at the cost of possibly being off by 1 RTT seems like a good optimization |
|
One of the specs seems to be broken, any idea what might've happened there? |
|
I came across the same sort of thing when working on #17 . It was due to an interaction with the stubbed scheduled set object. In that case I got past it by pulling in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimization. I'm not sure if this is less ideal due to the expiration saved potentially being +/- a second from the desired expiration due to I/O. Let me know.