Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a mock scheduled event object when preventing cron scheduling #720

Open
wants to merge 1 commit into
base: prevent-cron-frontend
Choose a base branch
from

Conversation

kadamwhite
Copy link
Contributor

Based on discussion in #702, this PR proposes an alternative return value which effectively prevents event scheduling.

In almost all cases within Core true would have been a valid value for timestamp, as it is almost always used in purely boolean checks. However there are one or two specific instances (wp_version_check, e.g.) where the timestamp is used in a numeric comparison. Returning an object with a timestamp perpetually one hour in the future feels like a viable hack to prevent event rescheduling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant