Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python unicode encoding problem when install gef in non-ascii locale #1127

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

fjh1997
Copy link
Contributor

@fjh1997 fjh1997 commented Aug 3, 2024

Description

To make python using UTF-8 when outputting to the pipe

Some users in Asian regions using non-ASCII languages may encounter issues when installing GEF with msys2 on Windows. The error message might be: "UnicodeEncodeError: 'gbk' codec can't encode character '\u21b3' in position 5137: illegal multibyte sequence." The reason is that Python is not using UTF-8 when outputting to the pipe, so the -x parameter needs to be added.

Make installation easier

image

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Copy link

github-actions bot commented Aug 3, 2024

🤖 Coverage update for c8746dd 🟢

Old New
Commit 8907935 c8746dd
Score 71.6267% 71.6267% (0)

@Grazfather Grazfather merged commit 674c74d into hugsy:main Aug 5, 2024
8 checks passed
@Grazfather
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants