Fix an incorrect scoped function call (introduced in #1093) #1124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1093, a call to
add_context_layout_mapping
was added without theself
scoping, causing a crash when external plugins add a context pane to GEF. I triggered this in the latest version of d2d:Checklist
Other Recommendations
If possible, I'd recommend adding a linter check as a requirement to the CI, so simple bugs like this can be caught :).